fix: preserve job order when using extends in remote configs #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes job execution order when using
extendsin remote configurations. Jobs from the base configuration now execute before jobs from the extending configuration, preserving dependency chains.Closes #1218
Problem
When a remote config uses
extendsto load another config, the job execution order was reversed:This broke dependency chains. For example, if a base config sets up dependencies (like
mise install) and an extending config adds additional checks (likeprettier), the checks would run before dependencies were installed.Root Cause
The
mergeJobsSlicefunction ininternal/config/load.goprocessed jobs in the wrong order:dest(existing/extending config) jobs firstsrc(new/base config) jobsThis order worked for local overrides but was incorrect for
extends, where the base should come first.Solution
This PR restructures
mergeJobsSliceto establish a clear semantic convention:src= base configuration (should execute first)dest= override/extension (should execute second)Changes made:
Refactored
mergeJobsSlice(internal/config/load.go:510-595):srcjobs first, thendestjobs{cmd}template replacement to work with the new orderUpdated
addHookcall (internal/config/load.go:373):src, local override asdestTesting
extendsin remote configs #1218: