Add RichCliRunner for testing Rich prompt/output capture#326
Open
mirs002 wants to merge 2 commits intoewels:mainfrom
Open
Add RichCliRunner for testing Rich prompt/output capture#326mirs002 wants to merge 2 commits intoewels:mainfrom
mirs002 wants to merge 2 commits intoewels:mainfrom
Conversation
Author
Note on the failing
|
Collaborator
|
Thanks! I'll review when I get a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rich_click.testing.RichCliRunner, aclick.testing.CliRunnersubclassCliRunner.isolation()so output goes to Click's isolated stdout/stderr streamsRichCliRunnerfromrich_clickWhy
When Rich's global console has already been initialized before
CliRunner.invoke(), prompt / console output may go to the pre-existing console stream instead of Click's test-captured streams. This makes asserting Rich prompt output difficult in tests.This change provides a dedicated runner for Rich-based CLIs that keeps Rich aligned with Click's test isolation.
Closes #232.