fetch-configlet: support fetching arm64 assets#805
Merged
ee7 merged 1 commit intoexercism:mainfrom Aug 22, 2023
Merged
Conversation
The most recent configlet release includes pre-built binaries for: - arm64 Linux [1] - arm64 macOS [2] - arm64 Windows [3] - riscv64 Linux [4] Support arm64 in the bash fetch-configlet script. Refs: 122 [1] 0e8d665, 2023-08-16, ".github, config: use Zig to cross-compile arm64 Linux asset" [2] f280445, 2023-08-17, ".github: cross-compile arm64 macOS asset" [3] 3824299, 2023-08-18, ".github, cli, completion: cross-compile arm64 Windows asset" [4] a962b18, 2023-08-17, ".github: cross-compile riscv64 Linux asset"
Member
Author
|
CI failure should be resolved by #806. |
Member
Author
|
@ErikSchierboom I'll leave updating the PowerShell script to you. But let's do that in a separate PR. Currently: configlet/scripts/fetch-configlet.ps1 Lines 15 to 16 in dca4119 I think it should also probably have the same logic change that I suggest in the top post. But it's less important. I suspect that we don't have a huge number of non-Windows PowerShell users, but we could consider resolving #361 at the same time. |
ErikSchierboom
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent configlet release includes pre-built binaries for:
Support arm64 in the bash fetch-configlet script.
Refs: #122
Follow-up from: #764 (comment)
I'll change the logic in this script in a later PR. I think we shouldn't hardcode the available binaries in the fetch scripts. Instead, we should try to download the configlet release for the user's machine, and error if the asset does not exist. Then we can add assets to the configlet releases without updating the fetch scripts on every track. That'll also make the fetch script support riscv64 Linux.
I suggest delaying the Exercism-wide PRs until we've done that.