Skip to content

create, README: fix descriptions of new options#858

Merged
ee7 merged 2 commits intoexercism:mainfrom
sanderploegsma:fix/create-options-help-text
Jan 21, 2024
Merged

create, README: fix descriptions of new options#858
ee7 merged 2 commits intoexercism:mainfrom
sanderploegsma:fix/create-options-help-text

Conversation

@sanderploegsma
Copy link
Copy Markdown
Contributor

The help text for the --practice-exercise and --concept-exercise options of configlet create were inverted:

Options for create:
      --approach <slug>           The slug of the approach
      --article <slug>            The slug of the article
      --practice-exercise <slug>  The slug of the concept exercise
      --concept-exercise <slug>   The slug of the practice exercise
  -e, --exercise <slug>           Only operate on this exercise
  -o, --offline                   Do not update the cached 'problem-specifications' data

This PR swaps them around.

@sanderploegsma
Copy link
Copy Markdown
Contributor Author

It looks like the CI failure is unrelated to the changes, not sure if it fails randomly more often. I can't seem to trigger a re-run myself though.

Copy link
Copy Markdown
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like the CI failure is unrelated to the changes

Yup, sorry. The Windows build is flaky, and we haven't yet diagnosed the cause: #829

@ee7 ee7 changed the title Fix typo in help text of create options create, README: fix descriptions of new options Jan 21, 2024
@ee7 ee7 merged commit ec0dd1f into exercism:main Jan 21, 2024
@sanderploegsma sanderploegsma deleted the fix/create-options-help-text branch January 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants