fetch_configlet: update, and remove duplicate script#1218
fetch_configlet: update, and remove duplicate script#1218jiegillet merged 1 commit intoexercism:mainfrom
Conversation
Commit eff52e6 "Update bin/fetch-configlet script" added a new up-to-date fetch script, rather than modifying the existing one. Remove the new script, and update the old one with the same upstream changes [1][2][3][4]: - fetch-configlet: allow running from the bin directory - fetch-configlet: add comment with upstream location - fetch-configlet: remove a hard line wrap - fetch-configlet: improve style slightly [1] exercism/configlet@3815d7a11ece [2] exercism/configlet@d304fa5f4291 [3] exercism/configlet@9c69c4d40827 [4] exercism/configlet@3b4b00983ac6
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
I would prefer the I don't feel strongly about having the script be extensionless, though. That's just an artifact of an earlier choice that I made without having strong feelings about the options. |
kytrinyx
left a comment
There was a problem hiding this comment.
I'm fine with merging this and then changing the extensions in a follow-on PR, if that is the outcome of the discussion.
Sounds good to me. I think we intended to get around to doing that. If we change the filename in this repo (which we would do if we add this file to Lines 4 to 5 in eff52e6 |
|
OK then, I'll merge this and expect a follow up PR with a name change (I do have a slight preference for having an extension). |
Commit eff52e6 "Update bin/fetch-configlet script" added a new up-to-date fetch script, rather than modifying the existing one.
Remove the new script, and update the old one with the same upstream changes:
3815d7afetch-configlet: allow running from the bin directoryd304fa5fetch-configlet: add comment with upstream location9c69c4dfetch-configlet: remove a hard line wrap3b4b009fetch-configlet: improve style slightlyFollow-up from #1217.
Alternatively, we could also remove the
.shscript instead. But if we prefer the extensionless name, maybe it's better to merge this PR first, then remove all.shfrom scripts in this repo as a follow-up PR.