fetch-configlet: pull upstream changes#1233
Merged
jiegillet merged 1 commit intoexercism:mainfrom Nov 18, 2022
Merged
Conversation
Contributor
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Member
Author
|
(I cycled draft status to request review from the necessary team, but we should merge the other PR first). |
Upstream changes: - print status and success message [1] - make some variables local [2] - support new configlet release asset names [3] [1] exercism/configlet@5f5b54d62d76 [2] exercism/configlet@013c66b61cb1 [3] exercism/configlet@57e6c5fdb3f3
jiegillet
force-pushed
the
fetch-configlet-update2
branch
from
d3f57d5 to
805c004
Compare
jiegillet
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This is a stacked PR. It will be for just the changes in d3f57d5
Before merging this PR, merge the below then rebase this PR on
main: