Skip to content

the-farm: fix go-staticcheck warning#2023

Merged
andrerfcsantos merged 1 commit intoexercism:mainfrom
Elfayer:fix-error-string-casing
Dec 25, 2021
Merged

the-farm: fix go-staticcheck warning#2023
andrerfcsantos merged 1 commit intoexercism:mainfrom
Elfayer:fix-error-string-casing

Conversation

@Elfayer
Copy link
Contributor

@Elfayer Elfayer commented Dec 25, 2021

Task2 asks for:

// negativeFiveFodder says there are -5.0 fodder
fodder, err := DivideFood(negativeFiveFodder, 10)
// fodder == 0.0
// err.Error() == "Negative fodder"

When I type return 0, errors.New("Negative fodder"), VSCode warns out: error strings should not be capitalized (ST1005) go-staticcheck
Same for Task3.

@github-actions
Copy link
Contributor

Dear Elfayer

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 🧦 If you changed the function signature or the function comment in the exemplar file or the stub file (<exercise>.go), make sure the change is applied to both files.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@Elfayer Elfayer force-pushed the fix-error-string-casing branch from d6c144f to b6d9a80 Compare December 25, 2021 15:13
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@andrerfcsantos andrerfcsantos added the x:size/small Small amount of work label Dec 25, 2021
@andrerfcsantos andrerfcsantos merged commit 43834c7 into exercism:main Dec 25, 2021
@Elfayer Elfayer deleted the fix-error-string-casing branch October 19, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants