Implementing protein-translation

[Average-user]

I wanted to use chunksOf from Data.List.Split but apparently it is not in the cabal configuration

[Average-user]

@petertseng The Travis errors are all because the README ¿aren't they?

[petertseng]

I will review when I am able. I am sorry to say that I am currently unable.

[Average-user]

@petertseng Don't worry, I have no rush. Too much AoC?

[petertseng]

The tests seems reasonable and the implementation is reasonable, so I think I only ask to change the placement and some versions.

There is the natural question of: Should either the nucleotides ACGU or the codons (Methionine, Tryptophan, etc) be made into a data, but I don't think it's needed, and I think I interpret #626 (comment) to agree with that (I hope I did not interpret)

[petertseng]

I think the extra space after then could go away

[petertseng]

1.0.1.1 because https://github.com/exercism/problem-specifications/blob/master/exercises/protein-translation/canonical-data.json#L3 says 1.0.1 (unless it changes after I wrote this comment)

It changed, so 1.1.0.1 is correct.

[petertseng]

I moved to lts-10.2

[petertseng]

I remind myself

[petertseng]

I wouldn't put this between hello-world and leap because leap seems easier since don't have to deal with lists or Maybe. So at the very least, after leap.

[Average-user]

And what about Data.List.Split? How can I do to make use of it?

[petertseng]

You are optionally free to do so if you want to, but it is not required. If you want ideas, you can see how other exercises use it.

$ git grep Split                                 (01-11 10:28)
exercises/atbash-cipher/examples/success-standard/src/Atbash.hs:import Data.List.Split (chunksOf)
exercises/crypto-square/examples/success-standard/src/CryptoSquare.hs:import Data.List.Split (chunksOf)
exercises/kindergarten-garden/examples/success-standard/src/Garden.hs:import Data.List.Split (chunksOf)
exercises/ocr-numbers/examples/success-standard/src/OCR.hs:import Data.List.Split (chunksOf)
exercises/word-count/examples/success-simple/src/WordCount.hs:import Data.List.Split (wordsBy)

[Average-user]

I know how to use it, but the build complains about it, dont know why

[petertseng]

should be good now

made it difficulty 3