Conversation
|
Oh, awesome! Thank you so much for all that work 💙 I should have some time on the weekend to review this PR in detail. |
angelikatyborska
left a comment
There was a problem hiding this comment.
I left a whole bunch of comments with feedback. I think there is some chaos in the type definitions and how they're used, and there's too much usage of as ... in the source code (not it tests, in tests in takes sense).
If you have more time to work on this PR, I would be happy to receive changes for my feedback, but if you don't have time anymore, I can also make those changes myself. Let me know!
I didn't test yet if the library still works after the changes. I would only do that later, at the end of the review process when I expect no more changes to be made to the source code (so that I don't have to test this more than once, it's a slow and manual process).
Thanks for the feedback. I'll work on your comments in the next few days and revert. |
|
Hi @angelikatyborska 👋🏾 ready for another review |
|
Thank you for the changes 🙏 I currently don't have time for open-source work, but this should change in a few weeks. Your contributions are appreciated and I WILL review them, just not right now. Sorry about that! |
Addressing #9