Fix issues for Mypy 0.950 and Pydantic 1.9.0#10786
Merged
svlandeg merged 13 commits intoexplosion:masterfrom May 25, 2022
Merged
Fix issues for Mypy 0.950 and Pydantic 1.9.0#10786svlandeg merged 13 commits intoexplosion:masterfrom
svlandeg merged 13 commits intoexplosion:masterfrom
Conversation
adrianeboyd
reviewed
May 13, 2022
|
Do you think this, will be available in the next release? |
svlandeg
added
enhancement
Contributor
Hi! We're planning to finish & release this for Thinc 8.1 and spaCy 3.4 🎉 |
svlandeg
reviewed
May 17, 2022
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
It's encouraging to see that we can remove so many ignores & casts, nice work Richard!
…dson/spacy into feature/mypy-fixes
danieldk
reviewed
May 23, 2022
danieldk
reviewed
May 23, 2022
danieldk
reviewed
May 23, 2022
danieldk
reviewed
May 23, 2022
Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
…dson/spacy into feature/mypy-fixes
danieldk
approved these changes
May 23, 2022
svlandeg
reviewed
May 24, 2022
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
This looks great Richard - nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This spaCy PR depends on explosion/thinc#599, so that this spaCy PR will not turn green until a version of Thinc is released that incorporates that Thinc PR.
Types of change
Mypy / Pydantic fixes
Checklist