Fix v4 branch to build against Thinc v9#11921
Merged
danieldk merged 4 commits intoexplosion:v4from Dec 17, 2022
Merged
Conversation
Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
danieldk
added
feat / parser
Contributor
|
@danieldk : we should run the GPU and slow tests here to make sure nothing broke (preferably after |
svlandeg
reviewed
Dec 15, 2022
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for this Daniel 🙏
This all looks sensible to me - though TBH I haven't gone in and reviewed every single line, assuming that most of this is copy/paste from previous work anyway, right?
Change SequenceCategoricalCrossentropy to LegacySequenceCategoricalCrossentropy. Eventually, we want to move to the new losses, but the goal of this PR is to make spaCy v4 work again.
Did you create a task on our internal board for v4 to ensure we don't forget this?
Contributor
Author
Yeah, they are only backports and some renaming for the losses.
Done. |
Contributor
Author
|
@explosion-bot please test_gpu |
Contributor
Author
|
@explosion-bot please test_slow |
Collaborator
URL: https://buildkite.com/explosion-ai/spacy-gpu-test-suite/builds/119 |
Collaborator
URL: https://buildkite.com/explosion-ai/spacy-slow-tests/builds/286 |
svlandeg
approved these changes
Dec 16, 2022
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Nice work! Good to merge by me :-)
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 14, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 14, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 29, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Apr 17, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Apr 17, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 3, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 3, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Move `thinc.extra.search` to `spacy.pipeline._parser_internals` Backport of: explosion#11317 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Replace references to `thinc.backends.linalg` with `CBlas` Backport of: explosion#11292 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com> * Use cross entropy from `thinc.legacy` * Require thinc>=9.0.0.dev0,<9.1.0 Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports some changes from the parser refactor to make the
v4branch compile against the Thincv9branch again. The backports are not cherry picks, since too many things changed between the parser versions to make this a clean cherry pick. Changes:thinc.extra.searchtospacy.pipeline._parser_internals#11317thinc.backends.linalgin the parser #11292SequenceCategoricalCrossentropytoLegacySequenceCategoricalCrossentropy. Eventually, we want to move to the new losses, but the goal of this PR is to make spaCy v4 work again.This PR also requires explosion/thinc#809.
Types of change
Checklist