Conversation
|
Oh, also |
|
Thanks! I'll check it out soon |
|
@ezolenko Hey I was just curious if there was any traction on this. |
|
Yes and no sorry, I have problems executing this on windows, but I haven't looked too closely on what exactly was wrong yet. |
|
@ezolenko |
|
Thanks for the updates. Could you merge everything from master and run a Also, could you move *.spec.ts files into their own directory at the same level as source, so there is |
|
I'm hoping to pick this PR/branch up soon, update it, and fix any issues. This plugin could really use some tests and this PR has been on my radar for a while. Will of course credit OP and use their commits as-is where possible (pending merge issues) or otherwise make them co-author if I make a new PR that gets squashed in. |
|
Have a WIP branch of this now, fully rebased with 3 years of commits, updated deps, updated config, moved to |
|
Replaced by #321 . Thanks again for writing this initial batch! |
Hey @ezolenko,
I saw in the README that you needed some unit tests -- I tried to add some decent coverage for the files here (though I think I may have misunderstood the build process (specifically the
tsProxystuff); if this branch is useful I'm happy to amend / continue this branch but as I'm about to start a new job in a couple days I figured it would be better to post this as is rather than let it languish.Additionally this is the first time I've written unit tests for TS -- I did some dirty checking of instances via
instance as anybut I think in general it has decent coverage for the files I started tests for.I hope it's ok, feedback appreciated.
Thanks,
Brekk