fix(docs): _.merge doesn't concat arrays#314
Merged
ezolenko merged 1 commit intoezolenko:masterfrom May 4, 2022
Merged
Conversation
- it's a deep merge that merges them by index - the rest of the docs are accurate, just this one mention was incorrect - eventually should move to shallow merge/replace arrays to better reflect how `tsconfig` `extends` works, but just fix the docs for now
agilgur5
added
the
scope: docs
agilgur5
added
the
kind: dx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small change to the docs to fix a reference to how
_.mergedeep merges work with arraysDetails
it's a deep merge that merges them by index
Per
includeintsconfigDefaultsis overridden by index from original tsconfig.json #226 (comment) , the rest of the docs are accurate, just this one mention was incorrectPer Shallow merge in
tsconfigOverridewhere TS does so -- matchtsconfigextends#86 (comment) , eventually should move to shallow merge/replace arrays to better reflect howtsconfigextendsworks (and principle of least surprise), but just fix the docs for nowReferences
Will be closing out #226 after this as it duplicates #86 otherwise