refactor(cache): simplify condition w/ optional chaining#356
Merged
ezolenko merged 1 commit intoezolenko:masterfrom Jun 14, 2022
Merged
refactor(cache): simplify condition w/ optional chaining#356ezolenko merged 1 commit intoezolenko:masterfrom
ezolenko merged 1 commit intoezolenko:masterfrom
Conversation
- as I've done in other places, simplify a condition by using optional chaining syntax (over the previously necessary syntax with `&&` etc) - also add a new line to the first `.map` here - for style consistency and because this is a super long line - this wasn't possible before the lodash refactor because it was all one big single statement in the chain
agilgur5
added
kind: internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify a conditional in
tscache.tsby using optional chainingDetails
as I've done in other places (e.g. refactor: invert some conditionals for better readability #335), simplify a condition by using optional chaining syntax (over the previously necessary syntax with
&&etc)also add a new line to the first
.maphere