test: add parse-tsconfig spec#397
Merged
ezolenko merged 3 commits intoezolenko:masterfrom Aug 19, 2022
Merged
Conversation
agilgur5
added
kind: internal
This was referenced Jul 22, 2022
- test passing tsconfig, buggy tsconfig, non-existent tsconfig, and not a tsconfig - clean: "failed to read" error will never happen as we already checked for existence of the file earlier - so remove the `undefined` check and instead use a non-null assertion (plus a comment explaining it) - refactor: move the integration test for tsconfig error into this unit test instead - faster / more efficient / more precise - refactor: split out a `makeOptions` func that creates default plugin options to use in tests - similar to `makeStubbedContext`
agilgur5
force-pushed
the
test-parse-tsconfig
branch
from
b30532d to
53b11df
Compare
agilgur5
added
the
topic: OS separators
This was referenced Jul 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for a few scenarios of
parse-tsconfig.tsDetails
test passing
tsconfig, buggytsconfig, non-existenttsconfig, and not atsconfigclean: "failed to read" error will never happen as we already checked for existence of the file earlier
undefinedcheck and instead use a non-null assertion (plus a comment explaining it)refactor: move the integration test for
tsconfigerror into this unit test insteadrefactor: split out a
makeOptionsfunc that creates default plugin options to use in testsmakeStubbedContextFuture Work
tsconfigs works correctly, not just that it doesn't throwtsconfigOverridewhere TS does so -- matchtsconfigextends#86 is implemented as that would no longer be a straightlodashdeep merge anymore