Conversation
agilgur5
reviewed
Sep 26, 2023
Collaborator
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
Quick glance through as I happened to already be on GH and got a notification
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
reviewed
Sep 26, 2023
Collaborator
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
looks like CI is passing now -- a few formatting things + a comment, otherwise LGTM
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
approved these changes
Sep 26, 2023
Collaborator
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
thanks for taking care of this!
agilgur5
added
the
kind: internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tslint is deprecated and now started to produce errors with new typescript
Details
Switching to typescript-eslint