Skip to content

fix: replace deprecated ArrayAccess methods (attach/detach/contains) … #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odysseuscm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace deprecated ArrayAccess methods (attach/detach/contains) … #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions library/HTMLPurifier/Injector/RemoveSpansWithoutAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public function handleElement(&$token)

if ($current instanceof HTMLPurifier_Token_End && $current->name === 'span') {
// Mark closing span tag for deletion
$this->markForDeletion->attach($current);
// PHP 8.5 compatiblity: replaced attach() with offsetSet()
$this->markForDeletion->offsetSet($current);
// Delete open span tag
$token = false;
}
Expand All @@ -85,8 +86,11 @@ public function handleElement(&$token)
*/
public function handleEnd(&$token)
{
if ($this->markForDeletion->contains($token)) {
$this->markForDeletion->detach($token);
// PHP 8.5 compatiblity:
// replaced contains() with offsetExists()
// replaced detach() with offsetUnset()
if ($this->markForDeletion->offsetExists($token)) {
$this->markForDeletion->offsetUnset($token);
$token = false;
}
}
Expand Down
Loading