fix: address repository discrepancies, bugs, and alignment with sister Rust repo#45
Merged
Merged
Conversation
…r Rust repo - Fix Dockerfile.singlearch case mismatch (Directory.packages.props → Directory.Packages.props) - Fix CI workflow chart tag (version → semVer) to match Rust repo - Fix build.sh shebang (#!/bin/sh → #!/usr/bin/env bash) for bash-specific features - Fix README.md: embedded script bug ($GIT_REPO → $GIT_REPOSITORY), sync with build.sh, update stale .NET 7.0 link to 10.0, align structure with Rust repo - Fix .dockerignore typo (explictly → explicitly) - Add missing .github/copilot-instructions.md aligned with Rust repo - Add missing charts NOTES.txt template aligned with Rust repo - Remove orphaned .scripts/Invoke-Setup.ps1 (DockerHub setup, no longer used) Co-authored-by: f2calv <16097639+f2calv@users.noreply.github.com> Agent-Logs-Url: https://github.com/f2calv/multi-arch-container-dotnet/sessions/86b79f97-d161-4c47-8e3f-e95d534333f4
Copilot created this pull request from a session on behalf of
f2calv
March 20, 2026 19:13
View session
f2calv
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive review of the repository to fix discrepancies, bugs, documentation issues, orphaned files, and structural misalignment with the sister repository multi-arch-container-rust.
Bug Fixes
Directory.packages.props→Directory.Packages.props— would fail on case-sensitive Linux filesystemsneeds.versioning.outputs.version→needs.versioning.outputs.semVer— consistent with the Rust repo and all other jobs in this workflow#!/bin/sh→#!/usr/bin/env bash— script uses bash-specificread -pwhich is not POSIX-compliantDocumentation Fixes
$GIT_REPO→$GIT_REPOSITORY)build.sh#!/usr/bin/env bashexplictly→explicitlyMissing Files Added (alignment with Rust repo)
.github/copilot-instructions.md: Created .NET-specific version with project structure, tech stack, build commands, configuration table, target platforms, and coding conventionscharts/.../templates/NOTES.txt: Created Helm chart notes template matching Rust repo structureOrphaned Files Removed
.scripts/Invoke-Setup.ps1: Removed DockerHub setup script that is no longer used (CI uses GHCR)CI Status
main)Security Summary
No security vulnerabilities were discovered. CodeQL scan returned 0 alerts.