Redirect int_maketodo's verbose output to stderr#1909
Open
colemole9595 wants to merge 2 commits intof4pga:masterfrom
Open
Redirect int_maketodo's verbose output to stderr#1909colemole9595 wants to merge 2 commits intof4pga:masterfrom
colemole9595 wants to merge 2 commits intof4pga:masterfrom
Conversation
acomodi
suggested changes
Apr 19, 2022
Contributor
acomodi
left a comment
acomodi
left a comment
There was a problem hiding this comment.
Hi @colemole9595, thanks for this PR. One small comment and I think we can run CI and merge if all is ok.
Signed-off-by: Anmol Shrivastava <colemole9595@gmail.com>
Signed-off-by: Anmol Shrivastava <colemole9595@gmail.com>
umarcor
force-pushed
the
maketodo_stderr
branch
from
963b16b to
b2b8c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int_maketodo.py's verbose messages are now sent to stderr. This pull request addresses #521.I ran
make format-py, is anything else needed?Signed-off-by: Anmol Shrivastava colemole9595@gmail.com