Skip to content

Add process.binding #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimenB wants to merge 1 commit into from
Closed

Add process.binding #5160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1917,6 +1917,7 @@ declare class Process extends events$EventEmitter {
abort() : void;
arch : string;
argv : Array<string>;
binding(id: string) : typeof exports;
chdir(directory : string) : void;
config : Object;
connected : boolean;
Expand Down
24 changes: 12 additions & 12 deletions tests/node_tests/node_tests.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,8 +2275,8 @@ Error: os/userInfo.js:14
Error: process/nextTick.js:13
13: (a: string, b: number, c: boolean) => {},
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function. This type is incompatible with the expected param type of
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1946
This parameter is incompatible:
14: 0, // Error: number ~> string
^ number. This type is incompatible with
Expand All @@ -2286,8 +2286,8 @@ Error: process/nextTick.js:13
Error: process/nextTick.js:13
13: (a: string, b: number, c: boolean) => {},
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function. This type is incompatible with the expected param type of
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1946
This parameter is incompatible:
16: null // Error: null ~> boolean
^^^^ null. This type is incompatible with
Expand All @@ -2297,8 +2297,8 @@ Error: process/nextTick.js:13
Error: process/nextTick.js:20
20: (a: string, b: number, c: boolean) => {},
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function. This type is incompatible with the expected param type of
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ function type. See lib: <BUILTINS>/node.js:1946
This parameter is incompatible:
22: 'y', // Error: string ~> number
^^^ string. This type is incompatible with
Expand All @@ -2308,20 +2308,20 @@ Error: process/nextTick.js:20
Error: process/nextTick.js:27
27: (a: string, b: number, c: boolean) => {} // Error: too few arguments
^^^^^^ string. This type is incompatible with
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1946

Error: process/nextTick.js:27
27: (a: string, b: number, c: boolean) => {} // Error: too few arguments
^^^^^^ number. This type is incompatible with
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1946

Error: process/nextTick.js:27
27: (a: string, b: number, c: boolean) => {} // Error: too few arguments
^^^^^^^ boolean. This type is incompatible with
1945: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1945
1946: nextTick: <T>(cb: (...T) => mixed, ...T) => void;
^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). See lib: <BUILTINS>/node.js:1946


Found 76 errors