Skip to content

Conversation

@Yonom
Copy link
Contributor

@Yonom Yonom commented Dec 13, 2021

Co-Authored-By: William Bell [email protected]

Summary

If one of the pods has no IPHONEOS_DEPLOYMENT_TARGET, the M1 postinstall workaround script fails. This commit updates the code to handle this special case.

Changelog

[iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround failing when one of the Pods has no IPHONEOS_DEPLOYMENT_TARGET set

Test Plan

reactwg/react-native-releases#6 (reply in thread)

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 13, 2021
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Dec 13, 2021
@analysis-bot
Copy link

analysis-bot commented Dec 13, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4fb49cd
Branch: main

@analysis-bot
Copy link

analysis-bot commented Dec 13, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,291,929 -1,113
android hermes armeabi-v7a 7,622,622 -1,033
android hermes x86 8,762,241 -1,379
android hermes x86_64 8,701,375 -1,155
android jsc arm64-v8a 9,680,208 -1,242
android jsc armeabi-v7a 8,667,587 -1,171
android jsc x86 9,636,020 -1,521
android jsc x86_64 10,232,757 -1,287

Base commit: 4fb49cd
Branch: main

@kelset
Copy link
Contributor

kelset commented Dec 13, 2021

cc @lunaleaps - we might want to cherry pick this into 0.67 branch too (if the other commit was also present there... or even both, tbh)

@lunaleaps
Copy link
Contributor

Yea I believe the original commit was already picked into 0.67, we should pick this one as well.

@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Yonom in 9cd4092.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 14, 2021
lunaleaps pushed a commit that referenced this pull request Dec 14, 2021
Summary:
Co-Authored-By: William Bell <[email protected]>

If one of the pods has no IPHONEOS_DEPLOYMENT_TARGET, the M1 postinstall workaround script fails. This commit updates the code to handle this special case.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround failing when one of the Pods has no IPHONEOS_DEPLOYMENT_TARGET set

Pull Request resolved: #32746

Test Plan: reactwg/react-native-releases#6 (reply in thread)

Reviewed By: charlesbdudley

Differential Revision: D33063717

Pulled By: lunaleaps

fbshipit-source-id: f45bc47c85e42ffb5c37a277fbedd48a729ef5fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants