-
Notifications
You must be signed in to change notification settings - Fork 25k
Fix error when pod has no IPHONEOS_DEPLOYMENT_TARGET #32746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: William Bell <[email protected]>
Base commit: 4fb49cd |
Base commit: 4fb49cd |
|
cc @lunaleaps - we might want to cherry pick this into 0.67 branch too (if the other commit was also present there... or even both, tbh) |
|
Yea I believe the original commit was already picked into 0.67, we should pick this one as well. |
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Co-authored-by: Tommy Nguyen <[email protected]>
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Yonom in 9cd4092. When will my fix make it into a release? | Upcoming Releases |
Summary: Co-Authored-By: William Bell <[email protected]> If one of the pods has no IPHONEOS_DEPLOYMENT_TARGET, the M1 postinstall workaround script fails. This commit updates the code to handle this special case. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround failing when one of the Pods has no IPHONEOS_DEPLOYMENT_TARGET set Pull Request resolved: #32746 Test Plan: reactwg/react-native-releases#6 (reply in thread) Reviewed By: charlesbdudley Differential Revision: D33063717 Pulled By: lunaleaps fbshipit-source-id: f45bc47c85e42ffb5c37a277fbedd48a729ef5fb
Co-Authored-By: William Bell [email protected]
Summary
If one of the pods has no IPHONEOS_DEPLOYMENT_TARGET, the M1 postinstall workaround script fails. This commit updates the code to handle this special case.
Changelog
[iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround failing when one of the Pods has no IPHONEOS_DEPLOYMENT_TARGET set
Test Plan
reactwg/react-native-releases#6 (reply in thread)