Skip to content

Refactor: RuntimeScheduler: Stop defaulting ctor args redundantly#43954

Closed
RSNara wants to merge 3 commits intofacebook:mainfrom
RSNara:export-D55547900
Closed

Refactor: RuntimeScheduler: Stop defaulting ctor args redundantly#43954
RSNara wants to merge 3 commits intofacebook:mainfrom
RSNara:export-D55547900

Conversation

@RSNara
Copy link
Contributor

@RSNara RSNara commented Apr 7, 2024

Summary:
Now, all the defaulting is in RuntimeScheduler.h.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547900

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 7, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 5552d27 to 4e7fcf3 Compare April 7, 2024 18:02
@analysis-bot
Copy link

analysis-bot commented Apr 7, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,217,880 +3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,594,630 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f77d028
Branch: main

@RSNara RSNara force-pushed the export-D55547900 branch from 4e7fcf3 to 25808ca Compare April 7, 2024 19:03
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 25808ca to d42171a Compare April 7, 2024 19:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from d42171a to 2a7233c Compare April 7, 2024 19:40
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 2a7233c to 467f116 Compare April 7, 2024 19:56
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 467f116 to e93326c Compare April 7, 2024 20:24
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from e93326c to 61604df Compare April 7, 2024 20:35
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from e6392a2 to e4cf4a8 Compare April 8, 2024 00:58
@RSNara RSNara force-pushed the export-D55547900 branch from e4cf4a8 to ca28ca4 Compare April 8, 2024 01:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from ca28ca4 to 3acff22 Compare April 8, 2024 01:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 3acff22 to 0b53bf1 Compare April 8, 2024 17:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

@RSNara RSNara force-pushed the export-D55547900 branch from 0b53bf1 to 32f4dfb Compare April 8, 2024 18:02
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

RSNara added 3 commits April 8, 2024 12:19
@RSNara @facebook-github-bot
Noop: ReactInstance: Add todo above getRuntimeScheduler()
55ef537 
Summary:
getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899
@RSNara @facebook-github-bot
Refactor: RuntimeScheduler: Delete ErrorUtils.h
15d6a0e 
Summary:
RuntimeScheduler's ErrorUtils.h is redundant.

Let's just remove it.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547905
@RSNara @facebook-github-bot
Refactor: RuntimeScheduler: Stop defaulting ctor args redundantly
f161d28 
Summary:
Now, all the defaulting is in RuntimeScheduler.h.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547900
@RSNara RSNara force-pushed the export-D55547900 branch from 32f4dfb to f161d28 Compare April 8, 2024 19:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547900

RSNara added a commit to RSNara/react-native that referenced this pull request Apr 8, 2024
@RSNara @facebook-github-bot
[skip ci] Refactor: RuntimeScheduler: Stop defaulting ctor args redun…
a0f3191 
…dantly (facebook#43954)

Summary:

Now, all the defaulting is in RuntimeScheduler.h.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547900
RSNara added a commit to RSNara/react-native that referenced this pull request Apr 8, 2024
@RSNara @facebook-github-bot
[skip ci] Refactor: RuntimeScheduler: Stop defaulting ctor args redun…
e08ead7 
…dantly (facebook#43954)

Summary:

Now, all the defaulting is in RuntimeScheduler.h.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547900
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 9, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 9, 2024

This pull request has been merged in 3382b15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSNara @facebook-github-bot @analysis-bot