Skip to content

Refactor: ReactInstance: Store JsErrorHandler inside a shared_ptr#43955

Closed
RSNara wants to merge 4 commits intofacebook:mainfrom
RSNara:export-D55547898
Closed

Refactor: ReactInstance: Store JsErrorHandler inside a shared_ptr#43955
RSNara wants to merge 4 commits intofacebook:mainfrom
RSNara:export-D55547898

Conversation

@RSNara
Copy link
Contributor

@RSNara RSNara commented Apr 7, 2024

Summary:
Just makes it easier to pass around JsErrorHandler.

We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler.

Changelog: [internal]

Reviewed By: cipolleschi

Differential Revision: D55547898

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 7, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@analysis-bot
Copy link

analysis-bot commented Apr 7, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,217,875 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,594,633 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f77d028
Branch: main

@RSNara RSNara force-pushed the export-D55547898 branch from a424381 to 23eae5c Compare April 7, 2024 19:04
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 23eae5c to 95480f5 Compare April 7, 2024 19:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 95480f5 to 793e1b8 Compare April 7, 2024 19:40
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 793e1b8 to 07a4761 Compare April 7, 2024 19:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 07a4761 to d78403e Compare April 7, 2024 20:24
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from d78403e to 07a7597 Compare April 7, 2024 20:36
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 07a7597 to 9522517 Compare April 7, 2024 23:42
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 9522517 to aa57b12 Compare April 8, 2024 01:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from aa57b12 to 451ea72 Compare April 8, 2024 01:14
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 451ea72 to 8dba001 Compare April 8, 2024 17:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from 8dba001 to b07c2cf Compare April 8, 2024 18:02
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

@RSNara RSNara force-pushed the export-D55547898 branch from b07c2cf to 4893e83 Compare April 8, 2024 18:23
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

RSNara added 4 commits April 8, 2024 12:19
@RSNara @facebook-github-bot
Noop: ReactInstance: Add todo above getRuntimeScheduler()
55ef537 
Summary:
getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899
@RSNara @facebook-github-bot
Refactor: RuntimeScheduler: Delete ErrorUtils.h
15d6a0e 
Summary:
RuntimeScheduler's ErrorUtils.h is redundant.

Let's just remove it.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547905
@RSNara @facebook-github-bot
Refactor: RuntimeScheduler: Stop defaulting ctor args redundantly
f161d28 
Summary:
Now, all the defaulting is in RuntimeScheduler.h.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547900
@RSNara @facebook-github-bot
Refactor: ReactInstance: Store JsErrorHandler inside a shared_ptr
8dbf114 
Summary:
Just makes it easier to pass around JsErrorHandler.

We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler.

Changelog: [internal]

Reviewed By: cipolleschi

Differential Revision: D55547898
@RSNara RSNara force-pushed the export-D55547898 branch from 4893e83 to 8dbf114 Compare April 8, 2024 19:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547898

RSNara added a commit to RSNara/react-native that referenced this pull request Apr 8, 2024
@RSNara @facebook-github-bot
[skip ci] Refactor: ReactInstance: Store JsErrorHandler inside a shar…
baaaba6 
…ed_ptr (facebook#43955)

Summary:

Just makes it easier to pass around JsErrorHandler.

We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler.

Changelog: [internal]

Reviewed By: cipolleschi

Differential Revision: D55547898
RSNara added a commit to RSNara/react-native that referenced this pull request Apr 8, 2024
@RSNara @facebook-github-bot
[skip ci] Refactor: ReactInstance: Store JsErrorHandler inside a shar…
8c223bf 
…ed_ptr (facebook#43955)

Summary:

Just makes it easier to pass around JsErrorHandler.

We'll need this in D55547897, when we start storing the "has fataled" boolean inside the JsErrorHandler.

Changelog: [internal]

Reviewed By: cipolleschi

Differential Revision: D55547898
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 9, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 9, 2024

This pull request has been merged in bffc54d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSNara @facebook-github-bot @analysis-bot