Skip to content

Move base64Encode into react/utils #55873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Move base64Encode into react/utils #55873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/NetworkIOAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
#include "NetworkIOAgent.h"
#include "InspectorFlags.h"

#include "Base64.h"
#include "Utf8.h"

#include <jsinspector-modern/network/NetworkHandler.h>
#include <react/utils/Base64.h>

#include <sstream>
#include <tuple>
Expand Down
4 changes: 2 additions & 2 deletions ...e/ReactCommon/jsinspector-modern/Base64.h → ...t-native/ReactCommon/react/utils/Base64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <string>
#include <string_view>

namespace facebook::react::jsinspector_modern {
namespace facebook::react {

namespace {
// Vendored from Folly
Expand Down Expand Up @@ -96,4 +96,4 @@ inline std::string base64Encode(const std::string_view s)
return res;
}

} // namespace facebook::react::jsinspector_modern
} // namespace facebook::react
Loading