Support ReadOnly/Readonly wrapped custom structs in C++ TurboModule codegen#56051
Open
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Open
Support ReadOnly/Readonly wrapped custom structs in C++ TurboModule codegen#56051christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96044884. |
meta-cla
bot
added
the
CLA Signed
…odegen (facebook#56051) Summary: When parsing custom struct types in RN TurboModule flow specs for C++ (cxxOnly) codegen, the `getObjectTypeAnnotations` function in `parsers-commons.js` silently dropped types wrapped in `$ReadOnly<{...}>` or `Readonly<{...}>`. The root cause: `parser.nextNodeForTypeAlias(value)` returns the raw right-hand side of a type alias. For `export type Foo = Readonly<{...}>`, this returns a `GenericTypeAnnotation` node (the `Readonly<...>` wrapper), not an `ObjectTypeAnnotation`. The existing guard check (`parent.type !== 'ObjectTypeAnnotation'`) then rejects the type, causing it to be silently skipped from the alias map. The fix unwraps `$ReadOnly`/`Readonly` `GenericTypeAnnotation` wrappers (Flow) and `Readonly` `TSTypeReference` wrappers (TypeScript) before performing the type check, then obtains properties directly from the unwrapped node. Also updates `NativeCxxModuleExample.js` to use `Readonly<{...}>` on `ConstantsStruct` as a demonstration and build-time validation of the fix. Changelog: [Internal] Differential Revision: D96044884
christophpurrer
force-pushed
the
export-D96044884
branch
from
e948c9d to
fe96e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When parsing custom struct types in RN TurboModule flow specs for C++ (cxxOnly) codegen, the
getObjectTypeAnnotationsfunction inparsers-commons.jssilently dropped types wrapped in$ReadOnly<{...}>orReadonly<{...}>.The root cause:
parser.nextNodeForTypeAlias(value)returns the raw right-hand side of a type alias. Forexport type Foo = Readonly<{...}>, this returns aGenericTypeAnnotationnode (theReadonly<...>wrapper), not anObjectTypeAnnotation. The existing guard check (parent.type !== 'ObjectTypeAnnotation') then rejects the type, causing it to be silently skipped from the alias map.The fix unwraps
$ReadOnly/ReadonlyGenericTypeAnnotationwrappers (Flow) andReadonlyTSTypeReferencewrappers (TypeScript) before performing the type check, then obtains properties directly from the unwrapped node.Also updates
NativeCxxModuleExample.jsto useReadonly<{...}>onConstantsStructas a demonstration and build-time validation of the fix.Changelog: [Internal]
Differential Revision: D96044884