Add $(inherited) to OTHER_LDFLAGS in xcodeproj template #7927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set $(inherited), then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting $(inherited) we are essentially overriding settings provided on project level (rather than target level) as well as .xcconfig level.
|
By analyzing the blame information on this pull request, we identified @alexeylang and @skozer to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
Member
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Jun 17, 2016
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this 
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this  If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this  If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this 
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig)
If we do not set
$(inherited), then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting$(inherited)we are essentially overriding settings provided on project level (rather than target level) as well as.xcconfiglevel.Test plan (required)
react-native init MyProject cd ios pod initNow go and add a pod to the
Podfile, sayAnd try to use it in
AppDelegate.mBefore this change, you'll get errors like this
After this change, the build will succeed.