Skip to content

Remove irrelevant suggestion of a legacy method from a warning #13169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 6 commits into from
Aug 2, 2018
Merged

Remove irrelevant suggestion of a legacy method from a warning #13169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
290f3b8
Edit warn message what use deprecated lifecycle method
Brew-Brew Jul 7, 2018
ba0b483
delete setState warn message about prescriptive and deprecated life c…
Brew-Brew Jul 11, 2018
b546cb4
fix lint
Brew-Brew Jul 11, 2018
7207d62
Merge branch 'master' into mymaster
gaearon Aug 2, 2018
ae49025
Prettier
gaearon Aug 2, 2018
7e1c3f6
Formatting
gaearon Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-dom/src/__tests__/ReactCompositeComponent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,7 @@ describe('ReactCompositeComponent', () => {
instance = ReactDOM.render(<Component />, container);
}).toWarnDev(
'Cannot update during an existing state transition (such as within ' +
"`render` or another component's constructor). Render methods should " +
'be a pure function of props and state; constructor side-effects are ' +
'an anti-pattern, but can be moved to `componentWillMount`.',
'`render`). Render methods should be a pure function of props and state.',
{withoutStack: true},
);

Expand Down
4 changes: 1 addition & 3 deletions packages/react-reconciler/src/ReactFiberScheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ if (__DEV__) {
warningWithoutStack(
false,
'Cannot update during an existing state transition (such as within ' +
"`render` or another component's constructor). Render methods should " +
'be a pure function of props and state; constructor side-effects are ' +
'an anti-pattern, but can be moved to `componentWillMount`.',
'`render`). Render methods should be a pure function of props and state.',
);
didWarnAboutStateTransition = true;
break;
Expand Down