sizebot: Fix wrong order of base, head arguments #20751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base and head arguments were flipped, so an n% decrease in bundle size was instead reported as an n% increase.
facebook-github-bot
added
CLA Signed
React Core Team
Size changesComparing: 4ecf119...fc4129a Stable channelNo significant bundle size changes to report. Experimental channelNo significant bundle size changes to report. |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
The base and head arguments were flipped, so an n% decrease in bundle size was instead reported as an n% increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base and head arguments were flipped, so an n% decrease in bundle size was instead reported as an n% increase.
Test plan
I pushed the commit to #20746 to confirm it fixes the sizebot results