Rename yarn build-combined to just yarn build #26192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
reviewed
Feb 17, 2023
| "build": "node ./scripts/rollup/build.js", | ||
| "build-combined": "node ./scripts/rollup/build-all-release-channels.js", | ||
| "build": "node ./scripts/rollup/build-all-release-channels.js", | ||
| "build-combined": "echo 'build-combined is deprecated. yarn build instead.'", |
Collaborator
There was a problem hiding this comment.
You could probably just delete this. I'm sure users will adapt quickly.
acdlite
approved these changes
Feb 17, 2023
sebmarkbage
force-pushed
the
buildcombined
branch
2 times, most recently
from
6a90640 to
bdc966a
Compare
|
Comparing: 1a49e2d...45e4c98 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
It's confusing to new contributors, and me, that you're supposed to use `yarn build-combined` for almost everything but not fixtures. We should use only one build command for everything.
sebmarkbage
force-pushed
the
buildcombined
branch
from
bdc966a to
45e4c98
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
It's confusing to new contributors, and me, that you're supposed to use `yarn build-combined` for almost everything but not fixtures. We should use only one build command for everything. Updated fixtures to use the folder convention of build-combined. DiffTrain build for [db5e625](db5e625) [View git log for this commit](https://github.com/facebook/react/commits/db5e6250d4bbb70c5085c58694a2e9c78c3f6371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing to new contributors, and me, that you're supposed to use
yarn build-combinedfor almost everything but not fixtures.We should use only one build command for everything.
Updated fixtures to use the folder convention of build-combined.