Remove react-tools #4010
Merged
Remove react-tools #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpao
force-pushed
the
really-deprecate-react-tools
branch
2 times, most recently
from
93300fa to
91a095c
Compare
Member
Author
|
Updated with the complete removal of react-tools. I left a couple of the other changes in-tact and then re-added jstransform and commoner to our devdeps (I hadn't done a fresh npm install to test last time…). We'll get rid of jstransform once we do #4130. |
Member
Author
|
cc @amasad. If react-native isn't ready to consume react from npm, we could build a new package that is just |
zpao
force-pushed
the
really-deprecate-react-tools
branch
from
91a095c to
bff47b9
Compare
Contributor
|
We can't because of the overrides? |
Member
Author
|
Yea, pretty much. But decoupling the overrides is not completely straightforward. |
This was referenced Jun 17, 2015
zpao
force-pushed
the
really-deprecate-react-tools
branch
from
bff47b9 to
d6bdd99
Compare
ReactTools is deprecated, it doesn't belong at the root of the project. We'll remove it after 0.14 but for now this moves it so that it's contained and not intermixed with the rest of the project. The currect behavior of copying src/ into the package is maintained.
zpao
force-pushed
the
really-deprecate-react-tools
branch
from
d6bdd99 to
94bc29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactTools is deprecated so lets remove it.