Use 'document.createEvent' not 'new Event'

[sophiebits]

Fixes #5153.

This seems to work in all browsers I tested, including old Android and all IE > 8 which didn't work before.

[sophiebits]

@sebmarkbage

[jimfb]

Looks reasonable to me.

[sebmarkbage]

The only reason I didn't use this to begin with is because of the scary deprecation notice on MDN.

Can you confirm you're not getting a deprecation warning?

Also add a feature test for createEvent just in case.

[sophiebits]

No deprecation warning in Firefox or Chrome.

createEvent is supported in everything since IE9 as far as I can tell. It was introduced in the same spec as dispatchEvent was. I can add a feature test if you really want one though?

[sebmarkbage]

Yea. I'm concerned that they would want to deprecate initEvent but not Event and dispatchEvent since that's what the documentation says. Not that I think browsers would but at least if we're careful they can't blame us for it.

On Oct 13, 2015, at 12:01 PM, Ben Alpert [email protected] wrote:

No deprecation warning in Firefox or Chrome.

createEvent is supported in everything since IE9 as far as I can tell. It was introduced in the same spec as dispatchEvent was. I can add a feature test if you really want one though?

—
Reply to this email directly or view it on GitHub.

[sophiebits]

#5166