Update polymer children using polymer api#5948
Closed
jimfb wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Contributor
Author
Collaborator
|
Polymer is supposed to be completely transparent. If you're loading Polymer before React and React doesn't work, it's a Polymer bug. |
Collaborator
|
ex: #1263 (comment) |
Contributor
Author
|
@spicyj: shady dom, not shadow dom. Reference: https://www.polymer-project.org/1.0/articles/shadydom.html#shady-dom-is-born |
Contributor
|
This feels very shady indeed.
|
Collaborator
|
Closing per #5948 (comment). We can open a separate issue if this is something we want to track. |
This was referenced Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For web components using polymer, we sometimes screw up the updates of children, because polymer uses a shady dom. This PR will use the polymer DOM api to update children IFF the user is using polymer, thereby ensuring that all DOM child operations happen correctly.