Skip to content

Stop relying on variable hoisting #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 1 commit into from
Nov 22, 2016
Merged

Stop relying on variable hoisting #8380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions docs/js/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,30 +1351,31 @@ typeof Set === 'function' && isNative(Set) &&
// Set.prototype.keys
Set.prototype != null && typeof Set.prototype.keys === 'function' && isNative(Set.prototype.keys);

var setItem, getItem, removeItem, getItemIDs, addRoot, removeRoot, getRootIDs;
if (canUseCollections) {
var itemMap = new Map();
var rootIDSet = new Set();

var setItem = function (id, item) {
setItem = function (id, item) {
itemMap.set(id, item);
};
var getItem = function (id) {
getItem = function (id) {
return itemMap.get(id);
};
var removeItem = function (id) {
removeItem = function (id) {
itemMap['delete'](id);
};
var getItemIDs = function () {
getItemIDs = function () {
return Array.from(itemMap.keys());
};

var addRoot = function (id) {
addRoot = function (id) {
rootIDSet.add(id);
};
var removeRoot = function (id) {
removeRoot = function (id) {
rootIDSet['delete'](id);
};
var getRootIDs = function () {
getRootIDs = function () {
return Array.from(rootIDSet.keys());
};
} else {
Expand All @@ -1390,31 +1391,31 @@ if (canUseCollections) {
return parseInt(key.substr(1), 10);
};

var setItem = function (id, item) {
setItem = function (id, item) {
var key = getKeyFromID(id);
itemByKey[key] = item;
};
var getItem = function (id) {
getItem = function (id) {
var key = getKeyFromID(id);
return itemByKey[key];
};
var removeItem = function (id) {
removeItem = function (id) {
var key = getKeyFromID(id);
delete itemByKey[key];
};
var getItemIDs = function () {
getItemIDs = function () {
return Object.keys(itemByKey).map(getIDFromKey);
};

var addRoot = function (id) {
addRoot = function (id) {
var key = getKeyFromID(id);
rootByKey[key] = true;
};
var removeRoot = function (id) {
removeRoot = function (id) {
var key = getKeyFromID(id);
delete rootByKey[key];
};
var getRootIDs = function () {
getRootIDs = function () {
return Object.keys(rootByKey).map(getIDFromKey);
};
}
Expand Down Expand Up @@ -3745,4 +3746,4 @@ module.exports = shouldUseNative() ? Object.assign : function (target, source) {
};

},{}]},{},[18])(18)
});
});