fixed wrong type for "allow_compaction" parameter#2487
Closed
jsteemann wants to merge 1 commit intofacebook:masterfrom
Closed
fixed wrong type for "allow_compaction" parameter#2487jsteemann wants to merge 1 commit intofacebook:masterfrom
jsteemann wants to merge 1 commit intofacebook:masterfrom
Conversation
should be boolean, not uint64_t MSVC complains about it during compilation with error `include\rocksdb\advanced_options.h(77): warning C4800: 'uint64_t': forcing value to bool 'true' or 'false' (performance warning)`
Contributor
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
Thanks! I too was about to fix it in #2480 :) |
Contributor
Author
|
@sagar0 : Sorry, I did not scan the other pull requests before I opened mine. |
Contributor
|
No worries. I wasn't complaining ... I was just mentioning that I too noticed the issue. |
siying
pushed a commit
that referenced
this pull request
Jun 26, 2017
Summary: should be boolean, not uint64_t MSVC complains about it during compilation with error `include\rocksdb\advanced_options.h(77): warning C4800: 'uint64_t': forcing value to bool 'true' or 'false' (performance warning)` Closes #2487 Differential Revision: D5310685 Pulled By: siying fbshipit-source-id: 719a33b3dba4f711aa72e3f229013c188015dc86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should be boolean, not uint64_t
MSVC complains about it during compilation with error
include\rocksdb\advanced_options.h(77): warning C4800: 'uint64_t': forcing value to bool 'true' or 'false' (performance warning)