Closed
Conversation
riversand963
approved these changes
Jan 11, 2022
Contributor
riversand963
left a comment
riversand963
left a comment
There was a problem hiding this comment.
LGTM as long as CI build passes. Left a couple of minor questions.
utilities/env_mirror.cc
Outdated
| char* bscratch = new char[n]; | ||
| Slice bslice; | ||
| size_t off = 0; | ||
| size_t off __attribute__((__unused__)) = 0; |
Contributor
Author
There was a problem hiding this comment.
It is used in assert(). So the compiler only complain when DEBUG_LEVEL=0.
Contributor
Author
There was a problem hiding this comment.
Windows build is failing for that. How about we only define that with in #ifndef NDEBUG?
Contributor
There was a problem hiding this comment.
Yeah, I think attribute is gcc/clang thing
| struct MutableDBOptions { | ||
| static const char* kName() { return "MutableDBOptions"; } | ||
| MutableDBOptions(); | ||
| explicit MutableDBOptions(const MutableDBOptions& options) = default; |
Contributor
There was a problem hiding this comment.
What is the error related to this copy constructor?
Contributor
Author
There was a problem hiding this comment.
Here is the error message:
./options/db_options.h:119:12: error: definition of implicit copy assignment operator for 'MutableDBOptions' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
explicit MutableDBOptions(const MutableDBOptions& options) = default;
^
db/db_impl/db_impl.cc:1229:27: note: in implicit copy assignment operator for 'rocksdb::MutableDBOptions' first required here
mutable_db_options_ = new_options;
|
|
||
| if (read_keys.find(i) == read_keys.end()) { | ||
| auto internal_key = InternalKey(key, 0, ValueType::kTypeValue); | ||
| total_useful_bytes += |
Contributor
There was a problem hiding this comment.
Does clang-13 think this var is not used?
Contributor
Author
There was a problem hiding this comment.
Yes, I think it is set but never used.
Contributor
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Mar 29, 2022
Summary: Pull Request resolved: facebook#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tikv/rocksdb
that referenced
this pull request
Mar 29, 2022
Summary: Pull Request resolved: facebook#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca Signed-off-by: tabokie <xy.tao@outlook.com> Co-authored-by: Jay Zhuang <zjay@fb.com>
Myasuka
pushed a commit
to Myasuka/rocksdb
that referenced
this pull request
Jul 18, 2022
Summary: Pull Request resolved: facebook#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca
Myasuka
pushed a commit
to Myasuka/frocksdb
that referenced
this pull request
Jul 18, 2022
Summary: Pull Request resolved: facebook/rocksdb#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca
Myasuka
pushed a commit
to Myasuka/frocksdb
that referenced
this pull request
Jul 18, 2022
Summary: Pull Request resolved: facebook/rocksdb#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca
fredia
pushed a commit
to fredia/frocksdb
that referenced
this pull request
Nov 21, 2022
Summary: Pull Request resolved: facebook/rocksdb#9374 Test Plan: Add CI for clang13 build Reviewed By: riversand963 Differential Revision: D33522867 Pulled By: jay-zhuang fbshipit-source-id: 642756825cf0b51e35861fb847ebaee4611b76ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: Add CI for clang13 build