pywatchman raises SystemError on Python 3.10

[ian-em]

The latest version of pywatchman (1.4.1) is not working on Python 3.10.

A SystemError occurs which can be reproduced as follows:

import pywatchman
client = pywatchman.client()
client.capabilityCheck()

This code will trigger SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats.

[jwatt]

I'm not familiar enough with watchman to even know where I can find pywatchman 1.4.1, but wasn't this issue fixed in the code a year ago in 6813a94?

[ian-em]

I'm not familiar enough with watchman to even know where I can find pywatchman 1.4.1, but wasn't this issue fixed in the code a year ago in 6813a94?

It looks like it was fixed in that commit, however for some reason there hasn't been a new release of pywatchman on pypi since September 1st 2017: https://pypi.org/project/pywatchman/#history

[jwatt]

@wez Would you still be the person to update pypi, or should we draw this to the attention of someone else nowadays? :-)

[wez]

@fanzeyi is more involved these days. I'll sync up with them to ensure that they have the ability to update pypi

[pauloxnet]

Please @jwatt @wez @fanzeyi release a new version of PyWatchman (in a wheel format) on PyPi, the package is abandoned there since 2017 as already reported in issue #503

[fanzeyi]

@pauloxnet Apologies for the delay and I will try to get a version out soon.

I have published a pre-release 1.4.2.dev1 of pywatchman to TestPyPi. You can find it at https://test.pypi.org/project/pywatchman/1.4.2.dev1/. I am worried dumping four years of change to PyPi directly might break something somewhere so I'd like to take it slow. I also would like to find sometime to fix our CI and have the package automatically published some time in the future.

That being said, I have built some wheels for Python 3.6 to 3.10 targeting manylinux2014 and macos-arm64 there in TestPyPi (I built them by hand, not CI, thus the lack of Windows and macos-amd64 :( ). Please use the following command to try it out. If everything works fine, I will make a pre-release to the mainline PyPi later this week for more testing.

pip install -i https://test.pypi.org/simple/ pywatchman==1.4.2.dev1

Thanks

---

Also, other people in this thread please give it a try as well. Thank you :)

[pauloxnet]

I'll have a look at it as soon as possible. in the meantime i shared your request to test the dev version on twitter. I hope it helps this phase.
https://twitter.com/pauloxnet/status/1475840504180924426?t=PNfe7Q3rGIN3S2ViChCAmA&s=19

[pauloxnet]

@fanzeyi I have successfully tested pywatchman 1.4.2.dev1 in these environments:

• Ubuntu 21.10 and Debian 11
• watchman 4.9.0 (system package installed via apt)
• Python 3.9.7 and Python 3.10.0
• Django 3.2.7 and Django 3.2.10

I hope others will test and report here. Thanks.

[niccolomineo]

v1.4.2 works fine on my end, please release it ASAP.

[adamchainz]

v1.4.2 also works for me on Python 3.10! I checked with Django and a standalone test script.

[pauloxnet]

@fanzeyi I think maybe we can release a 1.5.0 version instead of 1.4.2 due all last year changes.

[minusf]

@fanzeyi I think maybe we can release a 1.5.0 version instead of 1.4.2 due all last year changes.

or even 2.0, the new watchman is nothing like 4.9.0

[adamchainz]

Hey, sorry to be that developer, but can we have a release? pywatchman is broken on Python 3.10 until this is out.

[pauloxnet]

We seem to be at a standstill again, despite the positive feedback.
@jwatt @wez @fanzeyi , could any of you release a new pywatchman version on PyPi ?