Fix uninit_vector UB by returning Vec<MaybeUninit<T>>#410
Open
MavenRain wants to merge 1 commit intofacebook:mainfrom
Open
Fix uninit_vector UB by returning Vec<MaybeUninit<T>>#410MavenRain wants to merge 1 commit intofacebook:mainfrom
MavenRain wants to merge 1 commit intofacebook:mainfrom
Conversation
uninit_vector previously returned Vec<T> with uninitialized memory, which is undefined behavior (especially for types implementing Drop). Change return type to Vec<MaybeUninit<T>> and add assume_init_vec helper for zero-cost conversion after initialization. Update all ~30 call sites across math, crypto, fri, prover, and examples crates. Closes facebook#396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uninit_vector previously returned Vec with uninitialized memory, which is undefined behavior (especially for types implementing Drop). Change return type to Vec<MaybeUninit> and add assume_init_vec helper for zero-cost conversion after initialization. Update all ~30 call sites across math, crypto, fri, prover, and examples crates.
Closes #396