This repository was archived by the owner on Jan 13, 2022. It is now read-only.
When faceSize < FACE_SIZE_MIN, scale calculation is off #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inimum face size, the recalculated scale is wrong.
Contributor
|
Thanks for the pull request! I'll do some testing on this first, but it looks pretty good :) |
ehzhang
added a commit
that referenced
this pull request
Aug 11, 2015
When faceSize < FACE_SIZE_MIN, scale calculation is off
Contributor
|
Looks great! This will be a part of the next minor version release. |
sepo-one
pushed a commit
to One-com/fixed-data-table
that referenced
this pull request
Sep 3, 2017
* Create copy of state "collapsedRows" before manipulating Create copy of state "collapsedRows" before manipulating "Treat this.state as if it were immutable." from https://facebook.github.io/react/docs/react-component.html (bottom of page). The CollapseCell render was not being re-rendered unless recycled. E.G. ► was not changing to ▼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maximum top position of the scroll face should be {size - faceSize}.
max scroll position of the table = maxPosition = contentSize - size.
So the scale should be calculated as {(size-faceSize)/(contentSize - size)}, where faceSize = FACE_SIZE_MIN in this case.