Use intrusive_heap in timed_single_thread_context#650
Draft
ccotter wants to merge 1 commit intofacebookexperimental:mainfrom
Draft
Use intrusive_heap in timed_single_thread_context#650ccotter wants to merge 1 commit intofacebookexperimental:mainfrom
ccotter wants to merge 1 commit intofacebookexperimental:mainfrom
Conversation
Use a heap to avoid possibly linear enqueue operation time. Fixes facebookexperimental#648
facebook-github-bot
added
the
CLA Signed
Contributor
|
Thanks for the PR! Looking forward to approving it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a heap to avoid possibly linear enqueue operation time.
Fixes #648
Note: this doesn't quite accomplish what I wanted, since the
intrusive_heapis not a real heap (yet).