[WIP] Enforce nested traversals for Partition Scheduling#987
Draft
njriasan wants to merge 2 commits intofacebookexperimental:mainfrom
Draft
[WIP] Enforce nested traversals for Partition Scheduling#987njriasan wants to merge 2 commits intofacebookexperimental:mainfrom
njriasan wants to merge 2 commits intofacebookexperimental:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Partition scheduler only identifies top level load/store operations, which breaks our core assumptions about partition annotations in AutoWS. This updates the load/store to do a full walk.
The schedule is likely still suboptimal because similar to the for work the if is being assigned a partition.