Add deduce_jagged_tensor_with_graph_analysis flag for batch dim distinguish#929
Open
tissue3 wants to merge 1 commit intofacebookincubator:mainfrom
Open
Add deduce_jagged_tensor_with_graph_analysis flag for batch dim distinguish#929tissue3 wants to merge 1 commit intofacebookincubator:mainfrom
tissue3 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49262422 |
…nguish (facebookincubator#929) Summary: For vdd, it seems that the jagged tensor batch dim is identical to dense tensor batch dim, which caused issue in bmm kernel, that it cannot handle batch size as large as 2^16. This fix adds a flag `deduce_jagged_tensor_with_graph_analysis` so that when it is turnt on, we depend on graph analysis, i.e. `try_getting_jagged_tensor_map`, to deduce batch dim for jagged tensor. This can be more reliable than deducing based on value. Differential Revision: D49262422
tissue3
force-pushed
the
export-D49262422
branch
from
ac3913e to
6d87d33
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49262422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For vdd, it seems that the jagged tensor batch dim is identical to dense tensor batch dim, which caused issue in bmm kernel, that it cannot handle batch size as large as 2^16.
This fix adds a flag
deduce_jagged_tensor_with_graph_analysisso that when it is turnt on, we depend on graph analysis, i.e.try_getting_jagged_tensor_map, to deduce batch dim for jagged tensor. This can be more reliable than deducing based on value.Differential Revision: D49262422