Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Bug fix for D2#119

Merged
alcinos merged 1 commit intomasterfrom
d2
Jun 29, 2020
Merged

Bug fix for D2#119
alcinos merged 1 commit intomasterfrom
d2

Conversation

@alcinos
Copy link
Contributor

@alcinos alcinos commented Jun 29, 2020

Fixes #118

@alcinos alcinos requested a review from fmassa June 29, 2020 14:41
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2020
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

dictionnaries containing the two above keys for each decoder layer.
"""
if not isinstance(samples, NestedTensor):
if isinstance(samples, list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :)

@alcinos alcinos merged commit 14602a7 into master Jun 29, 2020
@fmassa fmassa deleted the d2 branch June 29, 2020 17:19
bjuncek pushed a commit to bjuncek/detr that referenced this pull request Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DETR Detectron2 Wrapper Errors

4 participants