Skip to content

allow @ in override value#1075

Merged
omry merged 1 commit intomasterfrom
email_value
Oct 19, 2020
Merged

allow @ in override value#1075
omry merged 1 commit intomasterfrom
email_value

Conversation

@omry
Copy link
Collaborator

@omry omry commented Oct 19, 2020

Closes #1074
cc @odelalleau

@omry omry requested a review from odelalleau October 19, 2020 16:20
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2020
@omry omry removed the request for review from odelalleau October 19, 2020 16:23
@omry omry merged commit cfb0ce7 into master Oct 19, 2020
@omry omry deleted the email_value branch October 19, 2020 18:04
@odelalleau
Copy link
Collaborator

odelalleau commented Oct 19, 2020

I'll update the OmegaConf grammar accordingly
(side note: you didn't update the parser grammar in the docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Cannot use overrides containing '@' character

3 participants