Conversation
facebook-github-bot
added
the
CLA Signed
jesszzzz
force-pushed
the
update_prismjs
branch
2 times, most recently
from
2d0f563 to
9bf47e8
Compare
jesszzzz
force-pushed
the
update_prismjs
branch
from
9bf47e8 to
743a70f
Compare
jesszzzz
force-pushed
the
update_prismjs
branch
from
743a70f to
245300e
Compare
andywag
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Prismjs is found to have a security issue (https://github.com/facebookresearch/hydra/security/dependabot/102).
It's being pulled in by the version of docusaurus we were using. This upgrades docusaurus to a newer version that doesn't use prismjs.
Along with this, we needed to
Also did some stuff to make the tests pass
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
yarn; yarn build; yarn startOpened the dev website and checked it looked right, pages loaded etc
CI/CD
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)