Quick (and dirty) fix to be able to install hydra despite pkg_ressources-gate#3132
Quick (and dirty) fix to be able to install hydra despite pkg_ressources-gate#3132jmichel-otb wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
…ssources-gate Fixes facebookresearch#3131 by removing the dependency to pkg_ressources.parse_requirements and import the content of requirements/requirements.txt directly instead of parsing it. There might be better way to fix this, such as completely removing setup.py and write a fully-fledged pyproject.toml instead. This is only a quick fix to allow downstream projects to install hydra again :(
|
Hi @jmichel-otb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
/tmp/pip-build-env-soxj_9x5/overlay/lib/python3.12/site-packages/setuptools/dist.py:765: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: MIT License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
|
@meta-hydra-bot I apologize but I am not going to sign a CLA just for this quick fix of 3 lines of code. I hope that the hydra team will make a proper fix for this problem, and in the mean time I share my workaround. |
1 participant
Motivation
This is only a quick fix to allow downstream projects to install hydra again :(
Closes #3131 by removing the dependency to
pkg_ressources.parse_requirementsand import the content ofrequirements/requirements.txtdirectly instead of parsing it.There might be better way to fix this, such as completely removing
setup.pyand write a fully-fledgedpyproject.tomlinstead.Have you read the Contributing Guidelines on pull requests?
No
Test Plan
See minimal example in #3131
Related Issues and PRs
#3131