fix overrides dropped when --multirun flag appears between them#3133
Open
Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Open
fix overrides dropped when --multirun flag appears between them#3133Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Mr-Neutr0n wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
argparse's nargs='*' positional stops consuming tokens when it hits an optional flag mid-sequence. so 'task=1 --multirun db=mysql' would only see task=1 as an override and reject db=mysql. switch to parse_known_args and merge leftover tokens back into the overrides list. flag ordering no longer matters. fixes facebookresearch#3053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--multirun(or any optional flag) is placed between override arguments on the command line, argparse only sees the overrides before the flag and rejects the rest as unrecognized. For example:This happens because
nargs="*"positional args stop consuming tokens as soon as argparse encounters an optional flag. The overrides after the flag never get picked up.Fixed by switching from
parse_args()toparse_known_args()and merging any remaining tokens back into the overrides list. All orderings now work:Fixes #3053