feat: manage opening status from provider to avoid closing on re-renders#3480
Open
RafaMellado wants to merge 1 commit intomainfrom
Open
feat: manage opening status from provider to avoid closing on re-renders#3480RafaMellado wants to merge 1 commit intomainfrom
RafaMellado wants to merge 1 commit intomainfrom
Conversation
RafaMellado
commented
Feb 19, 2026
|
|
||
| return ( | ||
| <div className="flex h-full min-h-0 flex-col gap-4"> | ||
| <OneTable loading={isLoading}> |
Contributor
Author
There was a problem hiding this comment.
All this introducing the Wrapper lol 😂
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
RafaMellado
force-pushed
the
nested-table/manage-rows-from-provider
branch
from
3ebc7b7 to
6df0712
Compare
Contributor
📦 Alpha Package Version PublishedUse Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using nested tables, we discovered that, when we updated the parent resource (from apollo cache), the row re-rendered and closed automatically the results.
With this change, we want to manage the opening status from outside, and avoid to lose what we interacted with the table on re-renders