feat(sdk): Fix for tests for python sdk and environment variables for…#80
Merged
avinashpipalwa merged 5 commits intofeat/sdk/analyticsapi-engines-sdk-generator-pr-44from Nov 19, 2021
Conversation
… examples Added changes for tests for python sdk. Fixed the username variables to get the username serial from the environment variables.
|
Can you remove the commented lines. |
Ramanth (Ramanth)
approved these changes
Nov 15, 2021
Contributor
Ramanth (Ramanth)
left a comment
Ramanth (Ramanth)
left a comment
There was a problem hiding this comment.
left minor comment
tests/test_linked_pa_templates.py
Outdated
| self.assertEqual(type(response[0].data[template_id]), | ||
| LinkedPATemplateSummary, "Response should be of LinkedPATemplateSummary type.") | ||
| self.assertEqual(type(response[0].data), | ||
| dict, "Response should be of LinkedPATemplateSummary type.") |
Contributor
There was a problem hiding this comment.
looks like you are checking for dict type twice and the validation message is different
Contributor
Author
There was a problem hiding this comment.
will change the validation message to dict type, missed this.
Removed commented lines. Changed the assert type.
avinashpipalwa
changed the base branch from
master
to
feat/sdk/analyticsapi-engines-sdk-generator-pr-44
ksreeramoj
approved these changes
Nov 17, 2021
Ramanth (Ramanth)
approved these changes
Nov 18, 2021
avinashpipalwa
merged commit 59c18d8
into
feat/sdk/analyticsapi-engines-sdk-generator-pr-44
avinashpipalwa
added a commit
that referenced
this pull request
Jan 10, 2022
* feat(sdk): Auto-commit from 'analyticsapi-engines-sdk-generator' repository PR 44 for SDK version v5.2.0 * feat(sdk): Fix for tests for python sdk and environment variables for… (#80) * feat(sdk): Fix for tests for python sdk and environment variables for examples Added changes for tests for python sdk. Fixed the username variables to get the username serial from the environment variables. * fix(sdk): fixed minor review comments Removed commented lines. Changed the assert type. * fix(sdk): Tests for Python SDK * feat(sdk): Fix tests for Python SDK * Fixed SDK integration tests and username and password variables Added FPO Integration tests and fixed example code snippet of FPO which was giving error while running. Changed the naming conventions for username and password variables as per FactSet standards. * Update test_fpo_calculations_api.py Co-authored-by: factset-sdk-bot <svc-fds-sdk-bot@factset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… examples
Added changes for tests for python sdk.
Fixed the username variables to get the username serial from the environment variables.