refactor(locale): normalize phone_number data#3518
Open
xDivisionByZerox wants to merge 2 commits intonextfrom
Open
refactor(locale): normalize phone_number data#3518xDivisionByZerox wants to merge 2 commits intonextfrom
xDivisionByZerox wants to merge 2 commits intonextfrom
Conversation
xDivisionByZerox
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3518 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2880 2880
Lines 220503 220503
Branches 951 952 +1
==========================================
- Hits 220450 220448 -2
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
Member
Author
There was a problem hiding this comment.
Comments inside data structures are not accounted for during the sorting. So we lose some comments here.
Member
Author
There was a problem hiding this comment.
This file contains some comments, which will be lost, as well.
ejcheng
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265.
Normalize the entries in the
phone_numbermodule definitions - in all locales. No entries have been removed. The changes are sorting only.How to verify
Checkout the branch:
The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:
You should end up with no changes in your work-tree.