Skip to content

feat(locale): add Japanese bird definitions#3719

Open
atzzCokeK wants to merge 5 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bird
Open

feat(locale): add Japanese bird definitions#3719
atzzCokeK wants to merge 5 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bird

Conversation

@atzzCokeK
Copy link
Contributor

Summary

Add bird definitions for the Japanese (ja) locale.

This enables faker.animal.bird() to generate Japanese bird names.

Added files

bird.ts - Bird species (40 items)

Wild birds in Japan

スズメ, カラス, ハト, ツバメ, メジロ, ウグイス, シジュウカラ, etc.

Pet birds

インコ, オウム, カナリア, 文鳥, セキセイインコ, オカメインコ, etc.

References

Test plan

  • pnpm run generate:locales executed successfully
  • pnpm run preflight passed

@netlify
Copy link

netlify bot commented Jan 31, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 34a1279
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69a0e8370863a4000872e4d0
😎 Deploy Preview https://deploy-preview-3719.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (2a4b15c) to head (34a1279).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3719   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         883      883           
  Lines        3061     3061           
  Branches      540      556   +16     
=======================================
  Hits         3027     3027           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/locales/ja/animal/index.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atzzCokeK atzzCokeK marked this pull request as ready for review February 26, 2026 05:30
@atzzCokeK atzzCokeK requested a review from a team as a code owner February 26, 2026 05:30
@atzzCokeK atzzCokeK force-pushed the feat/ja-animal-bird branch 2 times, most recently from 4bdcdc8 to fa67589 Compare February 26, 2026 05:40
@ST-DDT
Copy link
Member

ST-DDT commented Feb 26, 2026

Looks like you merged two PRs together here.

@atzzCokeK
Copy link
Contributor Author

atzzCokeK commented Feb 26, 2026

@ST-DDT My bad, I will fix it!

@ST-DDT
Copy link
Member

ST-DDT commented Feb 27, 2026

Also force pushing, resets any review progress for the maintainers, so please only use it when neccessary.

And if you use AI, then make sure that you as a human review your submissions first!

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Feb 27, 2026
@atzzCokeK
Copy link
Contributor Author

atzzCokeK commented Feb 27, 2026

And if you use AI, then make sure that you as a human review your submissions first!

@ST-DDT I am sorry, but honestly I did it by myself, not using AI with this fix.
Anyway, that is my mistake.

@atzzCokeK
Copy link
Contributor Author

Also force pushing, resets any review progress for the maintainers, so please only use it when neccessary.

I didn't know that happens in this project, I won't do it next time. Can I add this to CONTRIBUTING.md? If it is very common in OSS, just ignore me.

@atzzCokeK atzzCokeK requested a review from ST-DDT February 27, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants